Set up typechecking for DSL blocks #419
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
Contributor
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dersam
force-pushed
the
10-04-set_up_typechecking_for_dsl_blocks
branch
3 times, most recently
from
6e28202 to
9449467
Compare
dersam
commented
Oct 5, 2025
| @completed ||= false | ||
| end | ||
|
|
||
| #: { () [self: ConfigContext] -> void} -> void |
Contributor
Author
There was a problem hiding this comment.
This RBS type is what allows us to transparently rebind the self of the config and execute blocks.
dersam
commented
Oct 5, 2025
| module Roast | ||
| module DSL | ||
| class ConfigContext | ||
| #: (?Symbol?) {() [self: Roast::DSL::Cogs::Cmd::Config] -> void} -> void |
Contributor
Author
There was a problem hiding this comment.
Handwriting RBIs is a stopgap - I'll investigate doing this via a Tapioca compiler next, which will also give the same benefits to third party cogs.
Contributor
There was a problem hiding this comment.
I agree it makes sense to get it working first in a bare-bones way before investing in automation
juniper-shopify
approved these changes
Oct 7, 2025
Contributor
Author
dersam
changed the base branch from
10-03-set_up_cog_executor_with_dsl
to
graphite-base/419
dersam
force-pushed
the
10-04-set_up_typechecking_for_dsl_blocks
branch
from
9449467 to
4bc20f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of new Roast architecture. Sorbet typechecking will be used as a way to statically validate Roast workflows. Between Ruby syntax checking and Sorbet static analysis, we should be able to completely eliminate the frustrating syntax gotchas with the current default YAML workflow definitions.
Note: RBI shims are a placeholder, these will be replaced in the future with a tapioca compiler that will be able to generate RBIs for any cog.
I experimented with generics to apply types, but it ended up requiring the writing of some really ugly code. RBI generation with tapioca gives more idiomatic Ruby code while still providing the validations we want to supply.